linux-kernel - Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176b695b-6790-ff26-8c32-a3920639e6ca@gmail.com>
Date:   Tue, 21 Jan 2020 21:46:11 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jon Hunter <jonathanh@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, Jeff Brasen <jbrasen@...dia.com>
Subject: Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver

21.01.2020 21:34, Jon Hunter пишет:
> 
> On 21/01/2020 16:31, Dmitry Osipenko wrote:
>> Hello Jon,
>>
>> 20.01.2020 19:01, Jon Hunter пишет:
>>
>> [snip]
>>
>>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> +	if (!res)
>>> +		return -ENODEV;
>>> +
>>> +	port->membase = devm_ioremap(&pdev->dev, res->start,
>>> +				     resource_size(res));
>>
>> devm_platform_ioremap_resource()
> 
> That would be ideal, but we cannot. The driver needs the res structure
> as well later on.

Oh, indeed.