linux-kernel - Re: [PATCH] arm64: mm: support setting page attributes for debug situation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc61e0d5-b1cb-51b4-8d33-5a339fe59f1b@huawei.com>
Date:   Wed, 22 Jan 2020 11:46:06 +0800
From:   Yunfeng Ye <yeyunfeng@...wei.com>
To:     Will Deacon <will@...nel.org>
CC:     <catalin.marinas@....com>, <anshuman.khandual@....com>,
        <akpm@...ux-foundation.org>, <willy@...radead.org>,
        <ard.biesheuvel@....com>, <tglx@...utronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <hushiyuan@...wei.com>,
        <linfeilong@...wei.com>
Subject: Re: [PATCH] arm64: mm: support setting page attributes for debug
 situation



On 2020/1/16 19:09, Will Deacon wrote:
> On Fri, Jan 10, 2020 at 03:47:41PM +0800, yeyunfeng wrote:
>> When rodata_full is set or pagealloc debug is enabled, block mappings or
>> contiguou hints are no longer used for linear address area. Therefore,
>> support setting page attributes in this case is useful for debugging
>> memory corruption problems.
>>
>> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>
>> ---
>>  arch/arm64/mm/pageattr.c | 18 ++++++++++++++----
>>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> Although I can kind of see what you're getting at, I'm not keen on merging
> this without a user. If you're just referring to random debug hacks, then I
> think this change could be part of those too.
> 
Ok, thanks, I think when pagealloc debug is enabled, it is better not limited
to the vmap area only. and when kernel memory corruption problems happen, it's
useful to call set_memory_ro() function to debug these problem.

> Will
> 
> .
>