[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <325251e8-79e6-ed07-f5e0-b8c149757766@infradead.org>
Date: Wed, 22 Jan 2020 08:08:35 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: liaoweixiong <liaoweixiong@...winnertech.com>,
Kees Cook <keescook@...omium.org>,
Anton Vorontsov <anton@...msg.org>,
Colin Cross <ccross@...roid.com>,
Tony Luck <tony.luck@...el.com>,
Jonathan Corbet <corbet@....net>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Rob Herring <robh@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v1 06/11] Documentation: pstore/blk: blkoops: create
document for pstore_blk
On 1/22/20 7:01 AM, liaoweixiong wrote:
> On 2020/1/21 下午11:34, Randy Dunlap wrote:
>> On 1/21/20 12:19 AM, liaoweixiong wrote:
>>> hi Randy Dunlap,
>>>
>>> On 2020/1/21 2:36 PM, Randy Dunlap wrote:
>>>> On 1/20/20 9:23 PM, liaoweixiong wrote:
>>>>> hi Randy Dunlap,
>>>>>
>>>>> On 2020/1/21 PM12:13, Randy Dunlap wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I have some documentation comments for you:
>>>>>>
>>>>>>
>>>>>> On 1/19/20 5:03 PM, WeiXiong Liao wrote:
>>>>>>> The document, at Documentation/admin-guide/pstore-block.rst, tells us
>>>>>>> how to use pstore/blk and blkoops.
>>>>>>>
>>>>>>> Signed-off-by: WeiXiong Liao <liaoweixiong@...winnertech.com>
>>>>>>> ---
>>>>>>> Documentation/admin-guide/pstore-block.rst | 278 +++++++++++++++++++++++++++++
>>>>>>> MAINTAINERS | 1 +
>>>>>>> fs/pstore/Kconfig | 2 +
>>>>>>> 3 files changed, 281 insertions(+)
>>>>>>> create mode 100644 Documentation/admin-guide/pstore-block.rst
>>>>>>>
>>>>>>> diff --git a/Documentation/admin-guide/pstore-block.rst b/Documentation/admin-guide/pstore-block.rst
>>>>>>> new file mode 100644
>>>>>>> index 000000000000..58418d429c55
>>>>>>> --- /dev/null
>>>>>>> +++ b/Documentation/admin-guide/pstore-block.rst
>>>>>>> +Compression and header
>>>>>>> +----------------------
>>>>>>> +
>>>>>>> +Block device is large enough for uncompressed dmesg data. Actually we do not
>>>>>>> +recommend data compression because pstore/blk will insert some information into
>>>>>>> +the first line of dmesg data. For example::
>>>>>>> +
>>>>>>> + Panic: Total 16 times
>>>>>>> +
>>>>>>> +It means that it's the 16th times panic log since the first booting. Sometimes
>>>>>>
>>>>>> time of a panic log since ...
>>>>>>
>>>>>
>>>>> Should it be like this?
>>>>> It means the time of a panic log since the first booting.
>>>>
>>>> That sounds like clock time, not the number of instances or occurrences.
>>>>
>>>
>>> It is an oops/panic counter too. How about this?
>>>
>>> It means that it's OOPS/PANIC for the 16th time since the first booting.
>>
>> since the last booting {or boot}.
>>
>
> Not the last booting but the first booting. This is the number of
> triggers since the first time the system was installed.
OK, so it's a persistent counter.
Thanks for the clarification.
--
~Randy
Powered by blists - more mailing lists