linux-kernel - Re: [PATCH] locking/osq_lock: fix a data race in osq_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A5114711-B8DE-48DA-AFD0-62128AC08270@lca.pw>
Date:   Wed, 22 Jan 2020 12:08:47 -0500
From:   Qian Cai <cai@....pw>
To:     Will Deacon <will@...nel.org>
Cc:     mingo@...hat.com, peterz@...radead.org, elver@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/osq_lock: fix a data race in osq_wait_next



> On Jan 22, 2020, at 11:59 AM, Will Deacon <will@...nel.org> wrote:
> 
> I don't understand this; 'next' is a local variable.
> 
> Not keen on the onslaught of random "add a READ_ONCE() to shut the
> sanitiser up" patches we're going to get from kcsan :(

My fault. I suspect it is node->next. I’ll do a bit more testing to confirm.