linux-kernel - Re: [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fcea8bd9-2bea-ddb2-449e-8640e772c487@iogearbox.net>
Date:   Wed, 22 Jan 2020 18:24:01 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Chris Down <chris@...isdown.name>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Stanislav Fomichev <sdf@...gle.com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF
 to BTF transform

On 1/22/20 1:01 AM, Chris Down wrote:
> When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this
> error:
> 
>      % make -s
>      Failed to generate BTF for vmlinux
>      Try to disable CONFIG_DEBUG_INFO_BTF
>      make[3]: *** [vmlinux] Error 1
> 
> Compiling again without -s shows the true error (that pahole is
> missing), but since this is fatal, we should show the error
> unconditionally on stderr as well, not silence it using the `info`
> function. With this patch:
> 
>      % make -s
>      BTF: .tmp_vmlinux.btf: pahole (pahole) is not available
>      Failed to generate BTF for vmlinux
>      Try to disable CONFIG_DEBUG_INFO_BTF
>      make[3]: *** [vmlinux] Error 1
> 
> Signed-off-by: Chris Down <chris@...isdown.name>
> Cc: Stanislav Fomichev <sdf@...gle.com>
> Cc: Andrii Nakryiko <andriin@...com>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: bpf@...r.kernel.org
> Cc: kernel-team@...com

Applied, thanks!