linux-kernel - Re: [PATCH] block, bfq: improve arithmetic division in bfq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5d9c9a6-2678-6256-0e21-ec88dfc115b3@fb.com>
Date:   Wed, 22 Jan 2020 17:34:21 +0000
From:   Jens Axboe <axboe@...com>
To:     Wen Yang <wenyang@...ux.alibaba.com>,
        Paolo Valente <paolo.valente@...aro.org>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block, bfq: improve arithmetic division in bfq_delta()

On 1/20/20 3:04 AM, Wen Yang wrote:
> do_div() does a 64-by-32 division. Use div64_ul() instead of it
> if the divisor is unsigned long, to avoid truncation to 32-bit.
> And as a nice side effect also cleans up the function a bit.

Applied, thanks.

-- 
Jens Axboe