linux-kernel - Re: mq_notify loose notification request on fork()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 10:25:11 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Alexey Mateosyan <alexey.mateosyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Li Rongqing <lirongqing@...du.com>,
        Arnd Bergmann <arnd@...db.de>,
        Kees Cook <keescook@...omium.org>,
        David Howells <dhowells@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: mq_notify loose notification request on fork()

On Tue, 21 Jan 2020, Bueso wrote:
>diff --git a/fs/file.c b/fs/file.c
>index 2f4fcf985079..70e5fe1c70d5 100644
>--- a/fs/file.c
>+++ b/fs/file.c
>@@ -440,6 +440,7 @@ void exit_files(struct task_struct *tsk)
>
>	if (files) {
>		task_lock(tsk);
>+		files->tsk = NULL;

This part is wrong, of course, as we later need it. We can just remove
that statement.

Thanks,
Davidlohr