linux-kernel - Re: [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver for QEMU virt machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.2001221147260.248939@viisi.sifive.com>
Date:   Wed, 22 Jan 2020 11:49:54 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Anup Patel <Anup.Patel@....com>
cc:     Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Atish Patra <Atish.Patra@....com>,
        Alistair Francis <Alistair.Francis@....com>,
        Christoph Hellwig <hch@....de>,
        Anup Patel <anup@...infault.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver for QEMU virt
 machine

On Tue, 3 Dec 2019, Anup Patel wrote:

> We select Goldfish RTC driver using QEMU virt machine kconfig option
> to access RTC device on QEMU virt machine.
> 
> Signed-off-by: Anup Patel <anup.patel@....com>
> Reviewed-by: Atish Patra <atish.patra@....com>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

I just grepped for Goldfish through the QEMU git tree, and it didn't come 
up with anything.  Per our discussion last year: as a general matter of 
policy, until QEMU merges support for a simulated hardware device into 
their master branch, we shouldn't speculatively enable support for it.  
So, NAK from me on this one until that happens.


- Paul