linux-kernel - Re: [PATCH -next] drm/drm_dp_mst:remove set but not used variable 'origlen'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200122081906.GO43062@phenom.ffwll.local>
Date:   Wed, 22 Jan 2020 09:19:06 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Bo YU <tsu.yubo@...il.com>
Cc:     maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        irlied@...ux.ie, daniel@...ll.ch, airlied@...hat.com,
        tprevite@...il.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/drm_dp_mst:remove set but not used variable
 'origlen'

On Sat, Jan 18, 2020 at 04:06:28PM +0800, Bo YU wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/drm_dp_mst_topology.c:3693:16: warning: variable
> ‘origlen’ set but not used [-Wunused-but-set-variable]
>   int replylen, origlen, curreply;
> 
> It looks like never use variable origlen after assign value to it.
> 
> Fixes: ad7f8a1f9ced7 (drm/helper: add Displayport multi-stream helper (v0.6))
> Signed-off-by: Bo YU <tsu.yubo@...il.com>

Queued in drm-misc-next, thanks for your patch.
-Daniel

> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 4b74193b89ce..4c76e673206b 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -3690,7 +3690,7 @@ static bool drm_dp_get_one_sb_msg(struct drm_dp_mst_topology_mgr *mgr, bool up)
>  {
>  	int len;
>  	u8 replyblock[32];
> -	int replylen, origlen, curreply;
> +	int replylen, curreply;
>  	int ret;
>  	struct drm_dp_sideband_msg_rx *msg;
>  	int basereg = up ? DP_SIDEBAND_MSG_UP_REQ_BASE : DP_SIDEBAND_MSG_DOWN_REP_BASE;
> @@ -3710,7 +3710,6 @@ static bool drm_dp_get_one_sb_msg(struct drm_dp_mst_topology_mgr *mgr, bool up)
>  	}
>  	replylen = msg->curchunk_len + msg->curchunk_hdrlen;
>  
> -	origlen = replylen;
>  	replylen -= len;
>  	curreply = len;
>  	while (replylen > 0) {
> -- 
> 2.11.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch