linux-kernel - Re: [PATCH] staging: qlge: fix missing a blank line after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 09:44:36 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Valery Ivanov <ivalery111@...il.com>
Cc:     manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] staging: qlge: fix missing a blank line after declaration

On Sun, Jan 19, 2020 at 04:03:59PM +0200, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank lin after declarations"
> Issue found by checkpatch.pl
> 
> Signed-off-by: Valery Ivanov <ivalery111@...il.com>
> ---
>  drivers/staging/qlge/qlge_ethtool.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
> index 56d116d79e56..2872b7120e36 100644
> --- a/drivers/staging/qlge/qlge_ethtool.c
> +++ b/drivers/staging/qlge/qlge_ethtool.c
> @@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
>  			   struct ethtool_drvinfo *drvinfo)
>  {
>  	struct ql_adapter *qdev = netdev_priv(ndev);
> +
>  	strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
>  	strlcpy(drvinfo->version, qlge_driver_version,
>  		sizeof(drvinfo->version));
> @@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
>  static u32 ql_get_msglevel(struct net_device *ndev)
>  {
>  	struct ql_adapter *qdev = netdev_priv(ndev);
> +
>  	return qdev->msg_enable;
>  }
>  
>  static void ql_set_msglevel(struct net_device *ndev, u32 value)
>  {
>  	struct ql_adapter *qdev = netdev_priv(ndev);
> +
>  	qdev->msg_enable = value;
>  }
>  

This fix is already in my tree, always be sure to work against
linux-next for new development so you do not duplicate existing work.

thanks,

greg k-h