linux-kernel - Re: [PATCH] staging: exfat: remove fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200122085737.GA2511011@kroah.com>
Date:   Wed, 22 Jan 2020 09:57:37 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "T.Kohada" <Kohada.Tetsuhiro@...mitsubishielectric.co.jp>
Cc:     Mori.Takahiro@...mitsubishielectric.co.jp,
        motai.hirotaka@...mitsubishielectric.co.jp,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        linux-fsdevel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: exfat: remove fs_func struct.

On Fri, Jan 17, 2020 at 03:20:46PM +0900, T.Kohada wrote:
> Remove 'fs_func struct' and change indirect calls to direct calls.
> 
> The following issues are described in exfat's TODO.
> > Create helper function for exfat_set_entry_time () and
> > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through  the fs_func struc ponters ...
> 
> The fs_func struct was used for switching the helper functions of fat16/fat32/exfat.
> Now, it has lost the role of switching, just making the code less readable.
> 
> Signed-off-by: T.Kohada <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>

We need a "full" name here, not just an abbreviation, use what you would
for a document.

Also the patch does not apply to the linux-next tree at all, so I can't
take it.  Please rebase and resend.

thanks,

greg k-h