linux-kernel - Re: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <422bf3dc-2d9c-1a12-a7d3-a6dc9349a648@amd.com>
Date:   Wed, 22 Jan 2020 14:34:19 +0530
From:   "Thomas, Rijo-john" <Rijo-john.Thomas@....com>
To:     Hongbo Yao <yaohongbo@...wei.com>, jens.wiklander@...aro.org
Cc:     chenzhou10@...wei.com, tee-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "Rangasamy, Devaraj" <Devaraj.Rangasamy@....com>
Subject: Re: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD

+Deva, Herbert

Hi Hongbo,

On 22/01/20 12:46 pm, Hongbo Yao wrote:
> If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
> while building call.c or core.c
> 
> drivers/tee/amdtee/call.o: In function `handle_unload_ta':
> call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
> drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
> core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
> 
> Fix the config dependency for AMDTEE here.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
> Signed-off-by: Hongbo Yao <yaohongbo@...wei.com>

Reviewed-by: Rijo Thomas <Rijo-john.Thomas@....com>

You may have to resubmit this patch to linux-crypto list, so that it shows
up in patchwork and applied to cryptodev-2.6 tree

Thanks,
Rijo

> ---
>  drivers/tee/amdtee/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
> index 4e32b6413b41..191f9715fa9a 100644
> --- a/drivers/tee/amdtee/Kconfig
> +++ b/drivers/tee/amdtee/Kconfig
> @@ -3,6 +3,6 @@
>  config AMDTEE
>  	tristate "AMD-TEE"
>  	default m
> -	depends on CRYPTO_DEV_SP_PSP
> +	depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
>  	help
>  	  This implements AMD's Trusted Execution Environment (TEE) driver.
>