linux-kernel - Re: [PATCH 0/5] Lock warning clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200122012630.GE2935@paulmck-ThinkPad-P72>
Date:   Tue, 21 Jan 2020 17:26:30 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH 0/5] Lock warning clean up

On Mon, Jan 20, 2020 at 10:35:15PM +0000, Jules Irenge wrote:
> This patch series adds missing annotations to functions that register warnings of context imbalance when built with Sparse tool.
> The adds fix these warnings and give insight on what the functions are actually doing.
> In the core kernel,
> 
> 1. IRQ and RCU subsystems: exactly patch 1 and 3,  __releases() annotations were added as these functions exit the critical section
> 2. RCU subsystem again, patch 2 and 4, __acquire() annotations were added as the functions allow entry to the critical section.
> 3. TIME subsystem, patch 5 where lock is held at entry and exit of the function, an __must_hold() annotation was added.

Queued for review and testing, thank you!

I edited the commit logs, so please check to make sure that I did not
mess something up.

							Thanx, Paul

> Jules Irenge (5):
>   irq: Add  missing annotation for __irq_put_desc_unlock()
>   rcu: Add missing annotation for exit_tasks_rcu_start()
>   rcu: Add missing annotation for exit_tasks_rcu_finish()
>   rcu: Add missing annotation for rcu_nocb_bypass_lock()
>   time: Add missing annotation for __run_timer()
> 
>  kernel/irq/irqdesc.c     | 1 +
>  kernel/rcu/tree_plugin.h | 1 +
>  kernel/rcu/update.c      | 4 ++--
>  kernel/time/hrtimer.c    | 2 +-
>  4 files changed, 5 insertions(+), 3 deletions(-)
> 
> -- 
> 2.24.1
>