linux-kernel - Re: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <550c4e28-4826-dfef-9b8a-1d4290f52ff8@linux.alibaba.com>
Date:   Wed, 22 Jan 2020 10:06:15 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS



在 2020/1/21 下午11:18, Andy Shevchenko 写道:
> The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
> introduced some new test cases to the test_bitmap.c module. Among these
> it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
> 
> Reported-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  lib/test_bitmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 61ed71c1daba..6b13150667f5 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -278,6 +278,8 @@ static void __init test_replace(void)
>  	unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
>  	DECLARE_BITMAP(bmap, 1024);
>  
> +	BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
> +
>  	bitmap_zero(bmap, 1024);
>  	bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
>  	expect_eq_bitmap(bmap, exp3_0_1, nbits);
> 

It looks nice. :)

Reviewed-by: Alex Shi <alex.shi@...ux.alibaba.com>