linux-kernel - Re: [PATCH] of: irq: Export of_msi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af2d8b26-d651-6273-74ae-25a0b2fc7d0a@suse.com>
Date:   Wed, 22 Jan 2020 12:03:39 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, robh+dt@...nel.org,
        frowand.list@...il.com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: irq: Export of_msi_get_domain



On 22/01/2020 11:47, Peter Ujfalusi wrote:
> From: Matthias Brugger <matthias.bgg@...il.com>
> 
> Export of_mis_get_domain to enable it for users from outside.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> Hi Rob, Matthias,
> 
> I needed to resort to remove module build support for the new ringacc UDMA
> drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
> is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.
> 
> I have found this old patch in lkml, but can not see the history of why it is
> not applied.

The series it was part of was abandoned. The itself shouldn't have an issue.

Regards,
Matthias

> 
> Regards,
> Peter
> 
>  drivers/of/irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a296eaf52a5b..73017506ef00 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
>  
>  	return NULL;
>  }
> +EXPORT_SYMBOL_GPL(of_msi_get_domain);
>  
>  /**
>   * of_msi_configure - Set the msi_domain field of a device
>