linux-kernel - Re: [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 14:13:20 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Rishi Gupta <gupt21@...il.com>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        wsa+renesas@...g-engineering.com, gregkh@...uxfoundation.org,
        linux-i2c@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver

On Tue, Jan 21, 2020 at 10:14:20AM +0530, Rishi Gupta wrote:
> MCP2221 is a USB HID to I2C/SMbus host bridge device. This
> commit implements i2c and smbus host adapter support. 7-bit
> address and i2c multi-message transaction is also supported.
> 
> Signed-off-by: Rishi Gupta <gupt21@...il.com>

My main concern is there are quite some limitations in mcp_i2c_xfer().
Looking at them, I think we should just drop it. This seems to be an
SMBus controller, not I2C. Or?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)