linux-kernel - Re: [PATCH] x86/iperm: remove unused pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200122131559.GC20584@zn.tnic>
Date:   Wed, 22 Jan 2020 14:16:00 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Andy Lutomirski <luto@...nel.org>,
        Rik van Riel <riel@...riel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Waiman Long <longman@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/iperm: remove unused pointers

On Tue, Jan 21, 2020 at 04:40:54PM +0800, Alex Shi wrote:
> No one use the prev/next pointers in its function after commit 22fe5b0439dd
> ("x86/ioperm: Move TSS bitmap update to exit to user work"). So better to
> remove them.
> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Thomas Gleixner <tglx@...utronix.de> 
> Cc: Ingo Molnar <mingo@...hat.com> 
> Cc: Borislav Petkov <bp@...en8.de> 
> Cc: "H. Peter Anvin" <hpa@...or.com> 
> Cc: x86@...nel.org 
> Cc: Andy Lutomirski <luto@...nel.org> 
> Cc: Rik van Riel <riel@...riel.com> 
> Cc: Dave Hansen <dave.hansen@...el.com> 
> Cc: Waiman Long <longman@...hat.com> 
> Cc: Marcelo Tosatti <mtosatti@...hat.com> 
> Cc: linux-kernel@...r.kernel.org 
> ---
>  arch/x86/kernel/process.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 61e93a318983..839b5244e3b7 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)
>  
>  void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p)
>  {
> -	struct thread_struct *prev, *next;
>  	unsigned long tifp, tifn;
>  
> -	prev = &prev_p->thread;
> -	next = &next_p->thread;
> -
>  	tifn = READ_ONCE(task_thread_info(next_p)->flags);
>  	tifp = READ_ONCE(task_thread_info(prev_p)->flags);
>  
> -- 

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/cleanups&id=27353d5785bca61bb49cfd7c78e14f1d21e66ec5

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette