linux-kernel - Re: [PATCH v2] staging: exfat: remove fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200123084459.GA434861@kroah.com>
Date:   Thu, 23 Jan 2020 09:44:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tetsuhiro Kohada <Kohada.Tetsuhiro@...mitsubishielectric.co.jp>
Cc:     Valdis Kletnieks <valdis.kletnieks@...edu>,
        linux-fsdevel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Mori.Takahiro@...mitsubishielectric.co.jp,
        motai.hirotaka@...mitsubishielectric.co.jp
Subject: Re: [PATCH v2] staging: exfat: remove fs_func struct.

On Thu, Jan 23, 2020 at 05:32:58PM +0900, Tetsuhiro Kohada wrote:
> From: "Tetsuhiro Kohada" <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
> 
> Remove 'fs_func struct' and change indirect calls to direct calls.
> 
> The following issues are described in exfat's TODO.
> > Create helper function for exfat_set_entry_time () and
> > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through  the fs_func struc ponters ...
> 
> The fs_func struct was used for switching the helper functions of fat16/fat32/exfat.
> Now, it has lost the role of switching, just making the code less readable.
> 
> Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
> ---
>  drivers/staging/exfat/exfat.h       |  79 +++++-----
>  drivers/staging/exfat/exfat_core.c  | 214 +++++++++++-----------------
>  drivers/staging/exfat/exfat_super.c | 119 ++++++++--------
>  3 files changed, 178 insertions(+), 234 deletions(-)

What changed from v1?

Always put that below the --- line, as the documentation asks you to, so
that we know what is happening here.

Please fix that up and send a v3.

thanks,

greg k-h