linux-kernel - Re: [PATCH v4 37/38] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200123085616.GF2665@lahna.fi.intel.com>
Date:   Thu, 23 Jan 2020 10:56:16 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Darren Hart <dvhart@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Zha Qipeng <qipeng.zha@...el.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Mark Brown <broonie@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 37/38] platform/x86: intel_pmc_ipc: Convert to MFD

On Thu, Jan 23, 2020 at 08:01:42AM +0000, Lee Jones wrote:
> On Wed, 22 Jan 2020, Mika Westerberg wrote:
> 
> > On Wed, Jan 22, 2020 at 01:27:57PM +0000, Lee Jones wrote:
> > > > Which type of device you suggest here? And which bus it should be
> > > > registered to? I think we can make this create a platform_device but
> > > > then we would need to do that from the PCI driver as well which seems
> > > > unnecessary since we already have the struct pci_dev.
> > > 
> > > What kind of device is it?
> > 
> > It is either part of an ACPI device (platform_device) or a PCI device
> > depending on the platform.
> > 
> > > Refrain from using platform device, unless it is one please.
> > 
> > OK.
> > 
> > Greg suggested making the SCU IPC functionality a class and I think it
> > fits here nicely so I'm going to try that next if nobody objects. I'll
> > send the first cleanup patches separately.
> 
> Sounds good.

FYI, I the cleanup patch series can be found here:

https://www.spinics.net/lists/platform-driver-x86/msg20728.html
https://www.spinics.net/lists/platform-driver-x86/msg20729.html
https://www.spinics.net/lists/platform-driver-x86/msg20734.html
https://www.spinics.net/lists/platform-driver-x86/msg20750.html