linux-kernel - Re: [PATCH] media: platform: stm32: defer probe for auxiliary clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7573c97-7c88-bb3d-1bfb-dea92f146da9@st.com>
Date:   Thu, 23 Jan 2020 09:52:50 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Alexandre TORGUE" <alexandre.torgue@...com>,
        Etienne CARRIERE <etienne.carriere@...com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: platform: stm32: defer probe for auxiliary clock

Dears Yannick & Etienne,
Thank you for your patch,

Reviewed-by: Philippe Cornu <philippe.cornu@...com>

Philippe :-)

On 1/21/20 11:22 AM, Yannick Fertre wrote:
> From: Etienne Carriere <etienne.carriere@...com>
> 
> Change stm32-cec driver to defer probe when auxiliary clock
> "hdmi-cec" is registered in the system not has not been probed yet.
> 
> Signed-off-by: Etienne Carriere <etienne.carriere@...com>
> ---
>   drivers/media/platform/stm32/stm32-cec.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
> index 8a86b2c..543c9ec 100644
> --- a/drivers/media/platform/stm32/stm32-cec.c
> +++ b/drivers/media/platform/stm32/stm32-cec.c
> @@ -302,10 +302,14 @@ static int stm32_cec_probe(struct platform_device *pdev)
>   	}
>   
>   	cec->clk_hdmi_cec = devm_clk_get(&pdev->dev, "hdmi-cec");
> +	if (IS_ERR(cec->clk_hdmi_cec) &&
> +	    PTR_ERR(cec->clk_hdmi_cec) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;
> +
>   	if (!IS_ERR(cec->clk_hdmi_cec)) {
>   		ret = clk_prepare(cec->clk_hdmi_cec);
>   		if (ret) {
> -			dev_err(&pdev->dev, "Unable to prepare hdmi-cec clock\n");
> +			dev_err(&pdev->dev, "Can't prepare hdmi-cec clock\n");
>   			return ret;
>   		}
>   	}
>