linux-kernel - Re: [PATCH v3 0/9] arm64: dts: ti: UDMAP and McASP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jan 2020 18:05:22 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <t-kristo@...com>,
        <nm@...com>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/9] arm64: dts: ti: UDMAP and McASP support



On 23/01/20 5:15 PM, Peter Ujfalusi wrote:
> Hi,
> 
> Changes since v2:
> - Correct unit addresses for the McASP nodes
> - Remove unit address and label for MAIN and MCU NAVSS
> 
> Changes since v1:
> - rebased on ti-k3-next
> - Corrected j721e mcu_udma node: s/udmap/dma-controller
> - Moved the two McASP node patch at the end of the series
> 
> The ringacc and UDMA documentation and drivers are in next-20200122.
> 
> While adding the DMA support I have noticed few issues which is also fixed by
> this series.


Entire series looks good to me.

Reviewed-by: Lokesh Vutla <lokeshvutla@...com>

Thanks and regards,
Lokesh

> 
> Tero: I have included the McASP nodes as well to have examples for other
> peripherals on how he binding should be used.
> The patches for the McASP driver is not in next, but they are only internal
> driver changes (and Kconfig), not adding new DT dependencies.
> Since the McASP is disabled in SoC dtsi due to board level configuration needs
> it is not going to erroneously probe drivers.
> 
> It is up to you if you pick them or not, but I believe they serve a safe and
> nice example how the dma binding should be used for UDMA.
> 
> Regards,
> Peter
> ---
> Peter Ujfalusi (9):
>   arm64: dts: ti: k3-am65-main: Correct main NAVSS representation
>   arm64: dts: ti: k3-am65-main: Move secure proxy under cbass_main_navss
>   arm64: dts: ti: k3-am65: DMA support
>   arm64: dts: ti: k3-j721e: Correct the address for MAIN NAVSS
>   arm64: dts: ti: k3-j721e-main: Correct main NAVSS representation
>   arm64: dts: ti: k3-j721e-main: Move secure proxy and smmu under
>     main_navss
>   arm64: dts: ti: k3-j721e: DMA support
>   arm64: dts: ti: k3-am654-main: Add McASP nodes
>   arm64: dts: ti: k3-j721e-main: Add McASP nodes
> 
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 122 ++++++-
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi       |  46 +++
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 313 ++++++++++++++++--
>  .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      |  45 +++
>  arch/arm64/boot/dts/ti/k3-j721e.dtsi          |   2 +-
>  5 files changed, 491 insertions(+), 37 deletions(-)
>