linux-kernel - Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jan 2020 08:25:14 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
Cc:     linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Helen Koike <helen.koike@...labora.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Collabora Kernel ML <kernel@...labora.com>, dafna3@...il.com
Subject: Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

On Wed, Jan 22, 2020 at 7:46 AM Dafna Hirschfeld
<dafna.hirschfeld@...labora.com> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC     Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>

Fixes: d109ea0970cf ("dt-bindings: clock: Document external clocks for
MSM8998 gcc")
Acked-by: Rob Herring <robh@...nel.org>

> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 19d00794fe7d..50ff07f80acb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -220,6 +220,7 @@ examples:
>
>    # Example of MSM8998 GCC:
>    - |
> +    #include <dt-bindings/clock/qcom,rpmcc.h>
>      clock-controller@...000 {
>        compatible = "qcom,gcc-msm8998";
>        #clock-cells = <1>;
> --
> 2.17.1
>