linux-kernel - Re: [PATCH v3] [net]: Fix skb->csum update in inet_proto_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200123142929.GV795@breakpoint.cc>
Date:   Thu, 23 Jan 2020 15:29:29 +0100
From:   Florian Westphal <fw@...len.de>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Florian Westphal <fw@...len.de>,
        Praveen Chaudhary <praveen5582@...il.com>, pablo@...filter.org,
        davem@...emloft.net, kadlec@...filter.org,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zhenggen Xu <zxu@...kedin.com>,
        Andy Stracner <astracner@...kedin.com>
Subject: Re: [PATCH v3] [net]: Fix skb->csum update in
 inet_proto_csum_replace16().

Daniel Borkmann <daniel@...earbox.net> wrote:
> On 1/23/20 9:21 AM, Florian Westphal wrote:
> > So, AFAIU from what you're saying above the patch seems fine as-is and
> > just needs a more verbose commit message explaining why replace16()
> > doesn't update skb->csum while all the other ones do.
> > 
> > Is that correct?
> 
> Probably better a comment in the code to avoid confusion on why it's not done in
> inet_proto_csum_replace16() but all the other cases; mainly to avoid some folks
> in future sending random cleanup patches w/ removal attempts.

Makes sense, thanks!

Praveen, can you spin a v4 with a comment in replace16 that it
intentionally elides the skb->csum update because the function is
only used by ipv6?

Thanks!