linux-kernel - Re: [PATCH] ARM: OMAP2+: Fix undefined reference to omap_secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200123155040.GW5885@atomide.com>
Date:   Thu, 23 Jan 2020 07:50:40 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Dan Murphy <dmurphy@...com>
Cc:     "Andrew F. Davis" <afd@...com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: Fix undefined reference to omap_secure_init

* Dan Murphy <dmurphy@...com> [200122 18:10]:
> Andrew
> 
> On 1/22/20 11:20 AM, Andrew F. Davis wrote:
> > omap_secure_init() is now called from all OMAP2+ platforms during their
> > init_early() call. This function is in omap-secure.o so include that
> > in the build for these platforms.
> > 
> > Fixes: db711893eac8 ("ARM: OMAP2+: Add omap_secure_init callback hook for secure initialization")
> > Reported-by: Dan Murphy <dmurphy@...com>
> > Signed-off-by: Andrew F. Davis <afd@...com>
> > ---
> >   arch/arm/mach-omap2/Makefile | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index f07cfda85156..e1135b9d67c6 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -16,11 +16,11 @@ hwmod-common				= omap_hwmod.o omap_hwmod_reset.o \
> >   clock-common				= clock.o
> >   secure-common				= omap-smc.o omap-secure.o
> > -obj-$(CONFIG_ARCH_OMAP2) += $(omap-2-3-common) $(hwmod-common)
> > +obj-$(CONFIG_ARCH_OMAP2) += $(omap-2-3-common) $(hwmod-common) $(secure-common)
> >   obj-$(CONFIG_ARCH_OMAP3) += $(omap-2-3-common) $(hwmod-common) $(secure-common)
> >   obj-$(CONFIG_ARCH_OMAP4) += $(hwmod-common) $(secure-common)
> > -obj-$(CONFIG_SOC_AM33XX) += $(hwmod-common)
> > -obj-$(CONFIG_SOC_OMAP5)	 += $(hwmod-common) $(secure-common)
> > +obj-$(CONFIG_SOC_AM33XX) += $(hwmod-common) $(secure-common)
> > +obj-$(CONFIG_SOC_OMAP5)  += $(hwmod-common) $(secure-common)
> >   obj-$(CONFIG_SOC_AM43XX) += $(hwmod-common) $(secure-common)
> >   obj-$(CONFIG_SOC_DRA7XX) += $(hwmod-common) $(secure-common)
> 
> 
> Tested-by: Dan Murphy <dmurphy@...com>

Thanks applying into omap-for-v5.6/soc.

Regards,

Tony