linux-kernel - Re: [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65ae1560-241e-de68-a68a-ffea071f5cc4@oracle.com>
Date:   Thu, 23 Jan 2020 11:27:15 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Anchal Agarwal <anchalag@...zon.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        "Singh, Balbir" <sblbir@...zon.com>,
        "Valentin, Eduardo" <eduval@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "sstabellini@...nel.org" <sstabellini@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "pavel@....cz" <pavel@....cz>, "axboe@...nel.dk" <axboe@...nel.dk>,
        "x86@...nel.org" <x86@...nel.org>,
        "roger.pau@...rix.com" <roger.pau@...rix.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "Kamata, Munehisa" <kamatam@...zon.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "konrad.wilk@...cle.co" <konrad.wilk@...cle.com>,
        "len.brown@...el.com" <len.brown@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "fllinden@...ozn.com" <fllinden@...zon.com>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [RFC PATCH V2 11/11] x86: tsc: avoid system instability in
 hibernation



On 1/22/20 3:07 PM, Anchal Agarwal wrote:
>> In this case tsc_verify_tsc_adjust(true) this does nothing as
>> feature bit X86_FEATURE_TSC_ADJUST is not available to guest. 


Is it not available to your specific guest? Because AFAICT it is
available in general (to HVM/PVH guests).


> 4. Also, the instances do not have InvariantTSC exposed.

If you specify "nomigrate=true" in your configuration file you should
have that feature enabled.


-boris