linux-kernel - Re: [PATCH] lib: devres: Export devm_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAnfT0kBCmir+-cTkg+8bgO0pk+1S-rSfUVobf=Hzxz7g@mail.gmail.com>
Date:   Thu, 23 Jan 2020 20:16:35 +0200
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "Daniel Baluta (OSS)" <daniel.baluta@....nxp.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "info@...ux.net" <info@...ux.net>,
        "ztuowen@...il.com" <ztuowen@...il.com>,
        "sergei.shtylyov@...entembedded.com" 
        <sergei.shtylyov@...entembedded.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Daniel Baluta <daniel.baluta@....com>
Subject: Re: [PATCH] lib: devres: Export devm_ioremap_resource_wc

On Thu, Jan 23, 2020 at 7:57 PM gregkh@...uxfoundation.org
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Jan 23, 2020 at 03:47:21PM +0000, Daniel Baluta (OSS) wrote:
> > From: Daniel Baluta <daniel.baluta@....com>
> >
> > So that modules can also use it.
> >
> > Fixes: b873af620e58863b ("lib: devres: provide devm_ioremap_resource_wc()")
> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> > ---
> >  lib/devres.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/devres.c b/lib/devres.c
> > index 6ef51f159c54..7fe2bd75dfa3 100644
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> > @@ -182,6 +182,7 @@ void __iomem *devm_ioremap_resource_wc(struct device *dev,
> >  {
> >       return __devm_ioremap_resource(dev, res, DEVM_IOREMAP_WC);
> >  }
> > +EXPORT_SYMBOL(devm_ioremap_resource_wc);
>
> EXPORT_SYMBOL_GPL() perhaps?
>
> What in-tree driver needs this?

I was experimenting with an out of tree driver and I also was using it wrong :D.
Indeed looks like there is no real potential user so far in the kernel tree.

Perhaps: drivers/net/ethernet/amazon/ena/ena_netdev.c

Also, I chose EXPORT_SYMBOL because the same way its cousin
devm_ioremap_resource.

Daniel.