linux-kernel - Re: [PATCH net] net: bcmgenet: Use netif_tx_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abbd691d-592f-f58d-215b-0f40da485e76@gmail.com>
Date:   Thu, 23 Jan 2020 14:05:05 -0800
From:   Doug Berger <opendmb@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        "open list:BROADCOM GENET ETHERNET DRIVER" 
        <bcm-kernel-feedback-list@...adcom.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI

On 1/23/20 9:49 AM, Florian Fainelli wrote:
> Before commit 7587935cfa11 ("net: bcmgenet: move NAPI initialization to
> ring initialization") moved the code, this used to be
> netif_tx_napi_add(), but we lost that small semantic change in the
> process, restore that.
> 
> Fixes: 7587935cfa11 ("net: bcmgenet: move NAPI initialization to ring initialization")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 120fa05a39ff..0a8624be44a9 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -2164,8 +2164,8 @@ static void bcmgenet_init_tx_ring(struct bcmgenet_priv *priv,
>  				  DMA_END_ADDR);
>  
>  	/* Initialize Tx NAPI */
> -	netif_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> -		       NAPI_POLL_WEIGHT);
> +	netif_tx_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> +			  NAPI_POLL_WEIGHT);
>  }
>  
>  /* Initialize a RDMA ring */
> 

Acked-by: Doug Berger <opendmb@...il.com>

Thanks Florian!