linux-kernel - Re: [PATCH] module.h: Annotate mod_kallsyms with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200124043110.GD23699@madhuparna-HP-Notebook>
Date:   Fri, 24 Jan 2020 10:01:10 +0530
From:   Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     madhuparnabhowmik10@...il.com, linux-kernel@...r.kernel.org,
        joel@...lfernandes.org, frextrite@...il.com, rcu@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org, paulmck@...nel.org
Subject: Re: [PATCH] module.h: Annotate mod_kallsyms with __rcu

On Thu, Jan 23, 2020 at 06:22:58PM +0100, Jessica Yu wrote:
> +++ madhuparnabhowmik10@...il.com [22/01/20 22:34 +0530]:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> > 
> > This patch fixes the following sparse errors:
> > 
> > kernel/module.c:3623:9: error: incompatible types in comparison expression
> > kernel/module.c:4060:41: error: incompatible types in comparison expression
> > kernel/module.c:4203:28: error: incompatible types in comparison expression
> > kernel/module.c:4225:41: error: incompatible types in comparison expression
> > 
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> Hi Madhuparna,
> 
> Thanks, I can confirm this patch fixes the sparse warnings. I've
> applied it to modules-next.
>
Thank you Jessica.

Regards,
Madhuparna

> Jessica
> 
> > ---
> > include/linux/module.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/module.h b/include/linux/module.h
> > index bd165ba68617..dfdc8863e26a 100644
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -429,7 +429,7 @@ struct module {
> > 
> > #ifdef CONFIG_KALLSYMS
> > 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
> > -	struct mod_kallsyms *kallsyms;
> > +	struct mod_kallsyms __rcu *kallsyms;
> > 	struct mod_kallsyms core_kallsyms;
> > 
> > 	/* Section attributes */
> > -- 
> > 2.17.1
> >