| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200124123938.16524-2-shiju.jose@huawei.com>
Date: Fri, 24 Jan 2020 12:39:37 +0000
From: Shiju Jose <shiju.jose@...wei.com>
To: <linux-acpi@...r.kernel.org>, <linux-pci@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <rjw@...ysocki.net>,
<helgaas@...nel.org>, <lenb@...nel.org>, <bp@...en8.de>,
<james.morse@....com>, <tony.luck@...el.com>,
<gregkh@...uxfoundation.org>, <zhangliguang@...ux.alibaba.com>,
<tglx@...utronix.de>
CC: <linuxarm@...wei.com>, <jonathan.cameron@...wei.com>,
<tanxiaofei@...wei.com>, <yangyicong@...ilicon.com>,
Shiju Jose <shiju.jose@...wei.com>
Subject: [PATCH v2 1/2] ACPI: APEI: Add support to notify the vendor specific HW errors
Presently APEI does not support reporting the vendor specific
recoverable HW errors, received in the vendor defined table entries, to the
vendor drivers for the recovery.
This patch adds the support to register and unregister the
error handling function for the vendor specific HW errors and
to notify the registered kernel driver.
Signed-off-by: Shiju Jose <shiju.jose@...wei.com>
---
drivers/acpi/apei/ghes.c | 116 +++++++++++++++++++++++++++++++++++++++++++++--
include/acpi/ghes.h | 56 +++++++++++++++++++++++
2 files changed, 167 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 103acbb..69e18d7 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -490,6 +490,109 @@ static void ghes_handle_aer(struct acpi_hest_generic_data *gdata)
#endif
}
+struct ghes_event_notify {
+ struct list_head list;
+ struct rcu_head rcu_head;
+ guid_t sec_type; /* guid of the error record */
+ ghes_event_handler_t event_handler; /* event handler function */
+ void *data; /* handler driver's private data if any */
+};
+
+/* List to store the registered event handling functions */
+static DEFINE_MUTEX(ghes_event_notify_mutex);
+static LIST_HEAD(ghes_event_handler_list);
+
+/**
+ * ghes_register_event_handler - register an event handling
+ * function for the non-fatal HW errors.
+ * @sec_type: sec_type of the corresponding CPER to be notified.
+ * @event_handler: pointer to the error handling function.
+ * @data: handler driver's private data.
+ *
+ * return 0 : SUCCESS, non-zero : FAIL
+ */
+int ghes_register_event_handler(guid_t sec_type,
+ ghes_event_handler_t event_handler,
+ void *data)
+{
+ struct ghes_event_notify *event_notify;
+
+ event_notify = kzalloc(sizeof(*event_notify), GFP_KERNEL);
+ if (!event_notify)
+ return -ENOMEM;
+
+ event_notify->event_handler = event_handler;
+ guid_copy(&event_notify->sec_type, &sec_type);
+ event_notify->data = data;
+
+ mutex_lock(&ghes_event_notify_mutex);
+ list_add_rcu(&event_notify->list, &ghes_event_handler_list);
+ mutex_unlock(&ghes_event_notify_mutex);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(ghes_register_event_handler);
+
+/**
+ * ghes_unregister_event_handler - unregister the previously
+ * registered event handling function.
+ * @sec_type: sec_type of the corresponding CPER.
+ * @data: driver specific data to distinguish devices.
+ */
+void ghes_unregister_event_handler(guid_t sec_type, void *data)
+{
+ struct ghes_event_notify *event_notify;
+ bool found = false;
+
+ mutex_lock(&ghes_event_notify_mutex);
+ rcu_read_lock();
+ list_for_each_entry_rcu(event_notify,
+ &ghes_event_handler_list, list) {
+ if (guid_equal(&event_notify->sec_type, &sec_type)) {
+ if (data != event_notify->data)
+ continue;
+ list_del_rcu(&event_notify->list);
+ found = true;
+ break;
+ }
+ }
+ rcu_read_unlock();
+ mutex_unlock(&ghes_event_notify_mutex);
+
+ if (!found) {
+ pr_err("Tried to unregister a GHES event handler that has not been registered\n");
+ return;
+ }
+
+ synchronize_rcu();
+ kfree(event_notify);
+}
+EXPORT_SYMBOL_GPL(ghes_unregister_event_handler);
+
+static int ghes_handle_non_standard_event(guid_t *sec_type,
+ struct acpi_hest_generic_data *gdata, int sev)
+{
+ struct ghes_event_notify *event_notify;
+ bool found = false;
+ int ret;
+
+ rcu_read_lock();
+ list_for_each_entry_rcu(event_notify,
+ &ghes_event_handler_list, list) {
+ if (guid_equal(&event_notify->sec_type, sec_type)) {
+ ret = event_notify->event_handler(gdata, sev,
+ event_notify->data);
+ if (!ret)
+ continue;
+ found = true;
+ break;
+ }
+ }
+ rcu_read_unlock();
+
+ return found;
+}
+
static void ghes_do_proc(struct ghes *ghes,
const struct acpi_hest_generic_status *estatus)
{
@@ -525,11 +628,14 @@ static void ghes_do_proc(struct ghes *ghes,
log_arm_hw_error(err);
} else {
- void *err = acpi_hest_get_payload(gdata);
-
- log_non_standard_event(sec_type, fru_id, fru_text,
- sec_sev, err,
- gdata->error_data_length);
+ if (!ghes_handle_non_standard_event(sec_type, gdata,
+ sev)) {
+ void *err = acpi_hest_get_payload(gdata);
+
+ log_non_standard_event(sec_type, fru_id,
+ fru_text, sec_sev, err,
+ gdata->error_data_length);
+ }
}
}
}
diff --git a/include/acpi/ghes.h b/include/acpi/ghes.h
index e3f1cdd..e3387cf 100644
--- a/include/acpi/ghes.h
+++ b/include/acpi/ghes.h
@@ -50,6 +50,62 @@ enum {
GHES_SEV_PANIC = 0x3,
};
+enum {
+ GHES_EVENT_NONE = 0x0,
+ GHES_EVENT_HANDLED = 0x1,
+};
+
+/**
+ * typedef ghes_event_handler_t - event handling function
+ * for the non-fatal HW errors.
+ *
+ * @gdata: acpi_hest_generic_data.
+ * @sev: error severity of the entire error event defined in the
+ * ACPI spec table generic error status block.
+ * @data: handler driver's private data.
+ *
+ * Return : GHES_EVENT_NONE - event not handled, GHES_EVENT_HANDLED - handled.
+ *
+ * The error handling function is responsible for logging error and
+ * this function would be called in the interrupt context.
+ */
+typedef int (*ghes_event_handler_t)(struct acpi_hest_generic_data *gdata,
+ int sev, void *data);
+
+#ifdef CONFIG_ACPI_APEI_GHES
+/**
+ * ghes_register_event_handler - register an event handling
+ * function for the non-fatal HW errors.
+ * @sec_type: sec_type of the corresponding CPER to be notified.
+ * @event_handler: pointer to the event handling function.
+ * @data: handler driver's private data.
+ *
+ * Return : 0 - SUCCESS, non-zero - FAIL.
+ */
+int ghes_register_event_handler(guid_t sec_type,
+ ghes_event_handler_t event_handler,
+ void *data);
+
+/**
+ * ghes_unregister_event_handler - unregister the previously
+ * registered event handling function.
+ * @sec_type: sec_type of the corresponding CPER.
+ * @data: driver specific data to distinguish devices.
+ */
+void ghes_unregister_event_handler(guid_t sec_typei, void *data);
+#else
+static inline int ghes_register_event_handler(guid_t sec_type,
+ ghes_event_handler_t event_handler,
+ void *data)
+{
+ return -ENODEV;
+}
+
+static inline void ghes_unregister_event_handler(guid_t sec_type, void *data)
+{
+}
+#endif
+
int ghes_estatus_pool_init(int num_ghes);
/* From drivers/edac/ghes_edac.c */
--
1.9.1
Powered by blists - more mailing lists