linux-kernel - Re: [PATCH V4] firmware: arm_scmi: Make scmi core independent of the transport type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY3ZrzgH8q8Nz+VGjz9X9GOs+1_RxB7qgtyeLTZd8BR_0w@mail.gmail.com>
Date:   Fri, 24 Jan 2020 12:28:50 -0600
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Peter Hilber <peter.hilber@...nsynergy.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Sudeep Holla <Sudeep.Holla@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Cristian Marussi <cristian.marussi@....com>,
        Peng Fan <peng.fan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        ALKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V4] firmware: arm_scmi: Make scmi core independent of the
 transport type

On Fri, Jan 24, 2020 at 6:15 AM Peter Hilber
<peter.hilber@...nsynergy.com> wrote:
....
>
> I would have preferred (to have an option) to use as data passing
> interface to the transport just the struct scmi_xfer. A transport using
> this option would not implement ops (read|write)32 and memcpy_(from|to).
> The transport would also not call scmi_tx_prepare(), but instead take
> data from struct scmi_xfer directly. The transport would use a modified
> scmi_rx_callback() to notify that it updated the struct scmi_xfer. A
> helper to derive the struct scmi_xfer * from the message header would be
> extracted from scmi_rx_callback(). The scmi_xfer_poll_done() would
> become an (optional) transport op.
>
+1
I have pointed out many times the SCMI needs to realize not every
transport layer can conform to its expectations, the scmi_xfer must
have some transport specific element to it. Or there would be
emulation/pretend modes implemented in controller drivers.