linux-kernel - Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <825bf310-8ae6-ba62-1b70-709c738a7aa5@infradead.org>
Date:   Fri, 24 Jan 2020 12:23:57 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mark Brown <broonie@...nel.org>, Theodore Ts'o <tytso@....edu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: Document add_hwgenerator_randomness() with other
 input functions

On 1/24/20 5:41 AM, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/char/random.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index c7f9584de2c8..16070c36add3 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -228,6 +228,14 @@
>   * particular randomness source.  They do this by keeping track of the
>   * first and second order deltas of the event timings.
>   *
> + * There is also an interface for true hardware RNGs:
> + *
> + *	void add_hwgenerator_randomness(const char *buffer, size_t count,
> + *				size_t entropy);
> + *
> + * This will credit entropy as specified by the caller, if the entropy

Not a comma there. Either a ';' or "caller. If ..."

> + * pool is full it will block until more entropy is needed.
> + *
>   * Ensuring unpredictability at system startup
>   * ============================================
>   *
> 

thanks.
-- 
~Randy