linux-kernel - Re: linux-next: Tree for Jan 24 (kvm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200124213326.GQ2109@linux.intel.com>
Date:   Fri, 24 Jan 2020 13:33:26 -0800
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, KVM <kvm@...r.kernel.org>
Subject: Re: linux-next: Tree for Jan 24 (kvm)

On Fri, Jan 24, 2020 at 12:59:56PM -0800, Randy Dunlap wrote:
> On 1/24/20 12:51 PM, Randy Dunlap wrote:
> > On 1/23/20 10:33 PM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Changes since 20200123:
> >>
> >> The kvm tree gained a conflict against Linus' tree.
> >>
> > 
> > on i386:
> > 
> > ../arch/x86/kvm/x86.h:363:16: warning: right shift count >= width of type [-Wshift-count-overflow]
> > 
> > 
> 
> Sorry, I missed these 2 warnings:
> 
> ../arch/x86/kvm/vmx/vmx.c: In function 'vmx_set_msr':
> ../arch/x86/kvm/vmx/vmx.c:2001:14: warning: '~' on a boolean expression [-Wbool-operation]
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
> 
> 
> ../arch/x86/kvm/svm.c: In function 'svm_set_msr':
> ../arch/x86/kvm/svm.c:4289:14: warning: '~' on a boolean expression [-Wbool-operation]
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
> ../arch/x86/kvm/svm.c:4289:14: note: did you mean to use logical not?
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
>               !

Paolo has a fix in the works for this[1], pretty sure he's going to fixup
the offending commit directly[2].

Thanks!

[1] https://lkml.kernel.org/r/6b725990-f0c2-6577-be7e-44e101e540b5@redhat.com
[2] https://lkml.kernel.org/r/8f43bd04-9f4e-5c06-8d1d-cb84bba40278@redhat.com

> 
> -- 
> ~Randy
>