linux-kernel - Re: KASAN: slab-out-of-bounds Read in bitmap_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200124091144.GK1847@kadam>
Date:   Fri, 24 Jan 2020 12:11:44 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     syzbot <syzbot+b96275fd6ad891076ced@...kaller.appspotmail.com>,
        coreteam@...filter.org, davem@...emloft.net,
        florent.fourcot@...irst.fr, fw@...len.de, jeremy@...zel.net,
        johannes.berg@...el.com, kadlec@...filter.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, pablo@...filter.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: KASAN: slab-out-of-bounds Read in bitmap_port_destroy

On Fri, Jan 24, 2020 at 04:55:21PM +0800, Hillf Danton wrote:
> Ensure four bytes and ask slab to do the rest.
> 
> --- a/include/linux/netfilter/ipset/ip_set.h
> +++ b/include/linux/netfilter/ipset/ip_set.h
> @@ -430,7 +430,7 @@ ip6addrptr(const struct sk_buff *skb, bo
>  static inline int
>  bitmap_bytes(u32 a, u32 b)
>  {
> -	return 4 * ((((b - a + 8) / 8) + 3) / 4);
> +	return 4 + (b - a) / 8;
>  }
>  

Thanks, but this was already fixed by:

https://lore.kernel.org/netfilter-devel/alpine.DEB.2.20.2001192203200.18095@blackhole.kfki.hu/

regards,
dan carpenter