linux-kernel - Re: [PATCH RESEND] kernel/relay.c: fix read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200123172321.0ef6744e784692585f9843b3@linux-foundation.org>
Date:   Thu, 23 Jan 2020 17:23:21 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Pengcheng Yang <yangpc@...gsu.com>
Cc:     gregkh@...uxfoundation.org, jannh@...gle.com,
        viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] kernel/relay.c: fix read_pos error when multiple
 readers

On Wed, 22 Jan 2020 19:06:15 +0800 Pengcheng Yang <yangpc@...gsu.com> wrote:

> When reading, read_pos should start with bytes_consumed,
> not file->f_pos. Because when there is more than one reader,
> the read_pos corresponding to file->f_pos may have been consumed,
> which will cause the data that has been consumed to be read
> and the bytes_consumed update error.

That sounds fairly serious.  Are you able to describe a userspace setup
which will trigger this?  Do you have any test code which is able to
demonstrate the bug?

We really should have a relay testcase in tools/testing, but relay came
along before we became diligent about this.