linux-kernel - Re: [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tv4jhljx.fsf@mpe.ellerman.id.au>
Date:   Sat, 25 Jan 2020 21:34:10 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Will Deacon <will@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        kernel-team <kernel-team@...roid.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8

Nick Desaulniers <ndesaulniers@...gle.com> writes:
> On Fri, Jan 24, 2020 at 12:26 AM Peter Zijlstra <peterz@...radead.org> wrote:
>> On Thu, Jan 23, 2020 at 10:36:37AM -0800, Nick Desaulniers wrote:
>> > On Thu, Jan 23, 2020 at 7:34 AM Will Deacon <will@...nel.org> wrote:
>> > > It is very rare to see versions of GCC prior to 4.8 being used to build
>> > > the mainline kernel. These old compilers are also know to have codegen
>> > > issues which can lead to silent miscompilation:
>> > >
>> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
>> > >
>> > > Raise the minimum GCC version for kernel build to 4.8 and remove some
>> > > tautological Kconfig dependencies as a consequence.
>> > >
>> > > Cc: Nick Desaulniers <ndesaulniers@...gle.com>
>> >
>> > Thanks for the patch.
>> > Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>> > I wouldn't mind if this patch preceded the earlier one in the series
>> > adding the warning, should the series require a v2 and if folks are
>> > generally ok with bumping the min version.
>>
>> If I hadn't actually read your reply, I would have never spotted that
>> reviewed-by tag, hidden in a blob of text like that.
>>
>> Adding some whitespace before and after, such that it stands out a
>> little more, might avoid such issues.
>
> Ack. Do maintainers have tools for fetching patch series and
> automating collecting Reviewed-by tags, or is it all extremely manual?

Patchwork collects them for you. But not all maintainers use patchwork,
it's a bit new and trendy ;)

cheers