linux-kernel - [PATCH] staging: rtl8723bs: hal: fix condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200125134604.GA4247@google.com>
Date:   Sat, 25 Jan 2020 19:16:04 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     gregkh@...uxfoundation.org, saurav.girepunje@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: [PATCH] staging: rtl8723bs: hal: fix condition with no effect

fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)

Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
---
  drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
index 02da0a8..8dfa9b9 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
@@ -1610,8 +1610,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(13);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(14);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15);
  				} else {
@@ -1619,8 +1617,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(9);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(10);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11);
  				}
@@ -1630,8 +1626,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(5);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(6);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7);
  				} else {
@@ -1639,8 +1633,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(1);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(2);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3);
  				}
-- 
1.9.1