linux-kernel - Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200125162803.5a2375d7@xps13>
Date:   Sat, 25 Jan 2020 16:28:03 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Piotr Sroka <piotrs@...ence.com>,
        linux-um <linux-um@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Gow <davidgow@...gle.com>, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM
 dependency

Hi Brendan,

Brendan Higgins <brendanhiggins@...gle.com> wrote on Fri, 24 Jan 2020
18:12:12 -0800:

> On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> >
> > Hi Brendan,
> >
> > Brendan Higgins <brendanhiggins@...gle.com> wrote on Wed, 11 Dec 2019
> > 11:27:37 -0800:
> >  
> > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins@...gle.com>
> > > Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>
> > > ---  
> >
> > Sorry for the delay.
> >
> > Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>  
> 
> It looks like my change has not been applied to nand/next; is this the
> branch it should be applied to? I have also verified that this patch
> isn't in linux-next as of Jan 24th.
> 
> Is mtd/linux the correct tree for this? Or do I need to reach out to
> someone else?

When I sent my Acked-by I supposed someone else would pick the patch,
but there is actually no dependency with all the other patches so I
don't know why I did it... Sorry about that. I'll take it anyway in my
PR for 5.6.

Thanks,
Miquèl