linux-kernel - Re: [PATCH] fs/adfs: bigdir: Fix an error code in adfs_fplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200125163251.GL23230@ZenIV.linux.org.uk>
Date:   Sat, 25 Jan 2020 16:32:51 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Enrico Weigelt <info@...ux.net>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] fs/adfs: bigdir: Fix an error code in adfs_fplus_read()

On Sat, Jan 25, 2020 at 09:29:30AM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Jan 24, 2020 at 01:15:37PM +0300, Dan Carpenter wrote:
> > This code accidentally returns success, but it should return the
> > -EIO error code from adfs_fplus_validate_header().
> > 
> > Fixes: d79288b4f61b ("fs/adfs: bigdir: calculate and validate directory checkbyte")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Good catch.
> 
> Acked-by: Russell King <rmk+kernel@...linux.org.uk>
> 
> Al, please apply, thanks.

Applied and pushed out.