linux-kernel - Re: [PATCH V2] serial: 8250_tegra: Create Tegra specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202001260045.OfOvjLdk%lkp@intel.com>
Date:   Sun, 26 Jan 2020 00:54:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, Jeff Brasen <jbrasen@...dia.com>,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH V2] serial: 8250_tegra: Create Tegra specific 8250 driver

Hi Jon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on usb/usb-testing v5.5-rc7 next-20200124]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jon-Hunter/serial-8250_tegra-Create-Tegra-specific-8250-driver/20200125-195201
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_tegra.c: In function 'tegra_uart_probe':
>> drivers/tty/serial/8250/8250_tegra.c:80:18: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
     port->membase = devm_ioremap(&pdev->dev, res->start,
                     ^~~~~~~~~~~~
                     ioremap
>> drivers/tty/serial/8250/8250_tegra.c:80:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     port->membase = devm_ioremap(&pdev->dev, res->start,
                   ^
   cc1: some warnings being treated as errors

vim +80 drivers/tty/serial/8250/8250_tegra.c

    39	
    40	static int tegra_uart_probe(struct platform_device *pdev)
    41	{
    42		struct uart_8250_port port8250;
    43		struct tegra_uart *uart;
    44		struct uart_port *port;
    45		struct resource *res;
    46		int ret;
    47	
    48		uart = devm_kzalloc(&pdev->dev, sizeof(*uart), GFP_KERNEL);
    49		if (!uart)
    50			return -ENOMEM;
    51	
    52		memset(&port8250, 0, sizeof(port8250));
    53	
    54		port = &port8250.port;
    55		spin_lock_init(&port->lock);
    56	
    57		port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_FIXED_PORT |
    58			      UPF_FIXED_TYPE;
    59		port->iotype = UPIO_MEM32;
    60		port->regshift = 2;
    61		port->type = PORT_TEGRA;
    62		port->irqflags |= IRQF_SHARED;
    63		port->dev = &pdev->dev;
    64		port->handle_break = tegra_uart_handle_break;
    65	
    66		ret = of_alias_get_id(pdev->dev.of_node, "serial");
    67		if (ret >= 0)
    68			port->line = ret;
    69	
    70		ret = platform_get_irq(pdev, 0);
    71		if (ret < 0)
    72			return ret;
    73	
    74		port->irq = ret;
    75	
    76		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    77		if (!res)
    78			return -ENODEV;
    79	
  > 80		port->membase = devm_ioremap(&pdev->dev, res->start,
    81					     resource_size(res));
    82		if (!port->membase)
    83			return -ENOMEM;
    84	
    85		port->mapbase = res->start;
    86		port->mapsize = resource_size(res);
    87	
    88		uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
    89		if (IS_ERR(uart->rst))
    90			return PTR_ERR(uart->rst);
    91	
    92		if (device_property_read_u32(&pdev->dev, "clock-frequency",
    93					     &port->uartclk)) {
    94			uart->clk = devm_clk_get(&pdev->dev, NULL);
    95			if (IS_ERR(uart->clk)) {
    96				dev_err(&pdev->dev, "failed to get clock!\n");
    97				return -ENODEV;
    98			}
    99	
   100			ret = clk_prepare_enable(uart->clk);
   101			if (ret < 0)
   102				return ret;
   103	
   104			port->uartclk = clk_get_rate(uart->clk);
   105		}
   106	
   107		ret = reset_control_deassert(uart->rst);
   108		if (ret)
   109			goto err_clkdisable;
   110	
   111		ret = serial8250_register_8250_port(&port8250);
   112		if (ret < 0)
   113			goto err_clkdisable;
   114	
   115		platform_set_drvdata(pdev, uart);
   116		uart->line = ret;
   117	
   118		return 0;
   119	
   120	err_clkdisable:
   121		clk_disable_unprepare(uart->clk);
   122	
   123		return ret;
   124	}
   125	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49460 bytes)