linux-kernel - Re: [PATCH] tracing: Decrement trace_array when bootconfig creates an instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200124212531.4dc23b8c@rorschach.local.home>
Date:   Fri, 24 Jan 2020 21:25:31 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Divya Indi <divya.indi@...cle.com>
Subject: Re: [PATCH] tracing: Decrement trace_array when bootconfig creates
 an instance

On Sat, 25 Jan 2020 11:23:00 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> On Fri, 24 Jan 2020 20:59:27 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > 
> > From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> > 
> > The trace_array_get_by_name() creates a ftrace instance and
> > trace_array_put() is used to remove the reference. Even though the
> > trace_array_get_by_name() creates the instance, it also adds a reference
> > count to it, that prevents user space from removing it.
> > 
> > As the bootconfig just creates the instance on boot up, it should still be
> > used where it can be deleted by user space after boot. A trace_array_put()
> > is required to let that happen. Otherwise, the created instance can not
> > be removed.
> > 
> > Also, change the documentation on trace_array_get_by_name() to make this not
> > be so confusing.  
> 
> Good catch! I misunderstood trace_array_put() would remove the instance.

I figured as much, which is why I included the documentation update.

> 
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

-- Steve