linux-kernel - RE: [PATCH v3 1/4] Tools: hv: Reopen the devices if read() or write() returns errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK0P153MB014854B3EA48F86C722F1011BF080@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM>
Date:   Sun, 26 Jan 2020 04:59:31 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        vkuznets <vkuznets@...hat.com>
Subject: RE: [PATCH v3 1/4] Tools: hv: Reopen the devices if read() or write()
 returns errors

> From: Michael Kelley <mikelley@...rosoft.com>
> Sent: Saturday, January 25, 2020 8:49 PM
> > +reopen_fcopy_fd:
> > +	/* Remove any possible partially-copied file on error */
> > +	hv_copy_cancel();
> 
> Since you have removed the calls to close(fcopy_fd) after a
> pread() or pwrite() failure that were in v2 of the patch, I was
> expecting to see
> 
> 	if (fcopy_fd != -1)
> 		close(fcopy_fd)

I missed this... Thanks for catching it!
 
> here, like you've done with the kvp and vss code.  And
> remember to initialize fcopy_fd to -1. :-)
> 
> Michael

Will do it in v4.

Thanks,
-- Dexuan