linux-kernel - RE: [PATCH v4 2/4] hv_utils: Support host-initiated restart request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1052C5D5BD40F86DE4E3621BD7080@MW2PR2101MB1052.namprd21.prod.outlook.com>
Date:   Sun, 26 Jan 2020 06:05:44 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        vkuznets <vkuznets@...hat.com>
Subject: RE: [PATCH v4 2/4] hv_utils: Support host-initiated restart request

From: Dexuan Cui <decui@...rosoft.com> Sent: Saturday, January 25, 2020 9:50 PM
> 
> The hv_utils driver currently supports a "shutdown" operation initiated
> from the Hyper-V host. Newer versions of Hyper-V also support a "restart"
> operation. So add support for the updated protocol version that has
> "restart" support, and perform a clean reboot when such a message is
> received from Hyper-V.
> 
> To test the restart functionality, run this PowerShell command on the
> Hyper-V host:
> 
> Restart-VM  <vmname>  -Type Reboot
> 
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> 
> ---
> Changes in v2:
>    It's the same as v1.
> 
> Changes in v3 (I addressed Michael's comments):
>     Used a better version of changelog from  Michael.
>     Added a comment about the meaning of shutdown_msg->flags.
>     Call schedule_work() at the end of the function for consistency.
> 
> Changes in v4 (Thanks to Michael!):
>     Used a compact way to handle the work items.
> 
>  drivers/hv/hv_util.c | 39 +++++++++++++++++++++++++++++++--------
>  1 file changed, 31 insertions(+), 8 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>