linux-kernel - Re: [PATCH] staging: bcm2835-audio: fix warning of no space is necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200127084321.GV1847@kadam>
Date:   Mon, 27 Jan 2020 11:50:57 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Valery Ivanov <ivalery111@...il.com>
Cc:     nsaenzjulienne@...e.de, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: fix warning of no space is
 necessary

On Sun, Jan 26, 2020 at 07:37:58PM +0200, Valery Ivanov wrote:
> This patch fixes "No space is necessary after a cast".
> Issue found by checkpatch.pl
> 
> Signed-off-by: Valery Ivanov <ivalery111@...il.com>
> ---
>  drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> index 33485184a98a..997ce88c67c4 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> @@ -237,7 +237,7 @@ static void snd_bcm2835_pcm_transfer(struct snd_pcm_substream *substream,
>  {
>  	struct snd_pcm_runtime *runtime = substream->runtime;
>  	struct bcm2835_alsa_stream *alsa_stream = runtime->private_data;
> -	void *src = (void *) (substream->runtime->dma_area + rec->sw_data);
> +	void *src = (void *)(substream->runtime->dma_area + rec->sw_data);

There is no need for the cast to begin with.

regards,
dan carpenter