linux-kernel - Re: [PATCH] drivers: net: xgene: Fix the order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200127.111830.1055640381586578614.davem@davemloft.net>
Date:   Mon, 27 Jan 2020 11:18:30 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     isubramanian@....com, keyur@...amperecomputing.com,
        quan@...amperecomputing.com, tinamdar@....com, kdinh@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers: net: xgene: Fix the order

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sun, 26 Jan 2020 11:44:29 +0100

> 'alloc_etherdev_mqs()' expects first 'tx', then 'rx'. The semantic here
> looks reversed.
> 
> Reorder the arguments passed to 'alloc_etherdev_mqs()' in order to keep
> the correct semantic.
> 
> In fact, this is a no-op because both XGENE_NUM_[RT]X_RING are 8.
> 
> Fixes: 107dec2749fe ("drivers: net: xgene: Add support for multiple queues")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied, thanks.