linux-kernel - Re: [PATCH] tools lib api fs: Move cgroupsfs_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200127111234.GA1114818@krava>
Date:   Mon, 27 Jan 2020 12:12:34 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] tools lib api fs: Move cgroupsfs_find_mountpoint()

On Mon, Jan 27, 2020 at 07:00:31PM +0900, Namhyung Kim wrote:

SNIP

> -
> -	if (strlen(path) < maxlen) {
> -		strcpy(buf, path);
> -		return 0;
> -	}
> -	return -1;
> -}
> -
>  static int open_cgroup(const char *name)
>  {
>  	char path[PATH_MAX + 1];
> @@ -79,7 +20,7 @@ static int open_cgroup(const char *name)
>  	int fd;
>  
>  
> -	if (cgroupfs_find_mountpoint(mnt, PATH_MAX + 1))
> +	if (cgroupfs_find_mountpoint(mnt, PATH_MAX + 1, "perf_event"))

nice, but could you please follow fs API names and change the
name to cgroupfs__mountpoint

I think we don't need to define the rest of the functions now,
if they are not used

	#define FS(name)                                \
		const char *name##__mountpoint(void);   \
		const char *name##__mount(void);        \
		bool name##__configured(void);          \

just follow the function name

thanks,
jirka

>  		return -1;
>  
>  	scnprintf(path, PATH_MAX, "%s/%s", mnt, name);
> -- 
> 2.25.0.341.g760bfbb309-goog
>