linux-kernel - Re: [PATCH] arm64: Drop do_el0_ia_bp_hardening() & do_sp_pc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200127121538.GB5085@lakrids.cambridge.arm.com>
Date:   Mon, 27 Jan 2020 12:15:41 +0000
From:   Mark Rutland <Mark.Rutland@....com>
To:     Anshuman Khandual <Anshuman.Khandual@....com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Will Deacon <will@...nel.org>,
        James Morse <James.Morse@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: Drop do_el0_ia_bp_hardening() & do_sp_pc_abort()
 declarations

On Mon, Jan 27, 2020 at 03:19:35PM +0530, Anshuman Khandual wrote:
> There is a redundant do_sp_pc_abort() declaration in exceptions.h which can
> be removed. Also do_el0_ia_bp_hardening() as been already been dropped with
> the commit bfe298745afc ("arm64: entry-common: don't touch daif before
> bp-hardening") and hence does not need a declaration any more. This should
> not introduce any functional change.
>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: James Morse <james.morse@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
>  arch/arm64/include/asm/exception.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/include/asm/exception.h b/arch/arm64/include/asm/exception.h
> index b87c6e276ab1..7a6e81ca23a8 100644
> --- a/arch/arm64/include/asm/exception.h
> +++ b/arch/arm64/include/asm/exception.h
> @@ -33,7 +33,6 @@ static inline u32 disr_to_esr(u64 disr)
>
>  asmlinkage void enter_from_user_mode(void);
>  void do_mem_abort(unsigned long addr, unsigned int esr, struct pt_regs *regs);
> -void do_sp_pc_abort(unsigned long addr, unsigned int esr, struct pt_regs *regs);
>  void do_undefinstr(struct pt_regs *regs);
>  asmlinkage void bad_mode(struct pt_regs *regs, int reason, unsigned int esr);
>  void do_debug_exception(unsigned long addr_if_watchpoint, unsigned int esr,
> @@ -47,7 +46,4 @@ void bad_el0_sync(struct pt_regs *regs, int reason, unsigned int esr);
>  void do_cp15instr(unsigned int esr, struct pt_regs *regs);
>  void do_el0_svc(struct pt_regs *regs);
>  void do_el0_svc_compat(struct pt_regs *regs);
> -void do_el0_ia_bp_hardening(unsigned long addr,  unsigned int esr,
> -    struct pt_regs *regs);
> -
>  #endif/* __ASM_EXCEPTION_H */
> --
> 2.20.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.