linux-kernel - Re: [PATCH] dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9888d47-f320-57f4-5773-454673e5762d@ti.com>
Date:   Mon, 27 Jan 2020 17:54:21 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     <devicetree@...r.kernel.org>, Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Helen Koike <helen.koike@...labora.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Collabora Kernel ML <kernel@...labora.com>,
        <dafna3@...il.com>
Subject: Re: [PATCH] dt-bindings: fix compilation error of the example in
 intel,lgm-emmc-phy.yaml



On 24/01/20 7:59 pm, Dafna Hirschfeld wrote:
> 
> 
> On 24.01.20 15:03, Rob Herring wrote:
>> On Fri, Jan 24, 2020 at 5:49 AM Dafna Hirschfeld
>> <dafna.hirschfeld@...labora.com> wrote:
>>>
>>> Running:
>>> export
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>>>
>>> 'make dt_binding_check'
>>>
>>> gives a compilation error. This is because in the example there
>>> is the label 'emmc-phy' but labels are not allowed to have '-' sing.
>>> Replace the '-' with '_' to fix the error.
>>>
>>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
>>
>> There's a fix from the author, but you're first to get the fix
>> correct, so:
> Oh, sorry, I was not aware of that.
> Dafna
> 
>>
>> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
>> schema for LGM eMMC PHY")
>> Acked-by: Rob Herring <robh@...nel.org>
>>
>> Kishon, Please apply these soon as linux-next is broken.
>>

merged now, Thanks!

-Kishon