linux-kernel - Re: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Jan 2020 09:51:28 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Kuldeep Singh <kuldeep.singh@....com>,
        "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "cheol.yong.kim@...el.com" <cheol.yong.kim@...el.com>,
        "qi-ming.wu@...el.com" <qi-ming.wu@...el.com>
Subject: Re: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for
 the Cadence QSPI controller

Hi,

On 23/01/20 5:07 pm, Kuldeep Singh wrote:
> Hi Vignesh,
> 
[...]
>> I did test with s25fl512s with UBIFS and did not see any issue. 
> 
> Thanks Vignesh for this confirmation.
> 
>> Could you try with latest linux master or linux next? There were couple of fixes in the last -rc
>> related to spansion flashes?
> 
> Yes, I have already applied those patches and still facing this issue.
> I am testing with s25fs512s and only able to make it work on 1bit mode and that too by skipping SFDP.

Hmm, why would you need to skip SFDP parsing in 1 bit mode? What
actually fails when SFDP is parsed? Read/write/erase? BTW, did s25fs512s
flash ever with you controller before (i.e is this a regression)?

> Basic read/write works on other modes but not FS utilities.
> Could you please share any pointer to look into which direction. Thanks in advance.
> 

If 1 bit mode works fine, then probably flash FS in 1 bit mode and they
try read only mount in quad mode. Thus try and narrow down if the issue
is in read path vs write path.

Regards
Vignesh

> Thanks
> Kuldeep
> 
>>
>> [1]
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kerne
>> l.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git%2Fcommit
>> %2F%3Fh%3Dmtd%2Ffixes%26id%3D440b6d50254bdbd84c2a665c7f53ec69dd
>> 741a4f&amp;data=02%7C01%7Ckuldeep.singh%40nxp.com%7Cee345bdf9f654
>> 4ac9f4508d79fd863d9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7
>> C637153624041330774&amp;sdata=OyKGl2jn5JDq5KCaVrxAnUh4qSynmAhS%
>> 2FeFiOxJSKtU%3D&amp;reserved=0
>> [2]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
>> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git%2Fcomm
>> it%2F%3Fh%3Dmtd%2Ffixes%26id%3Dda2ef8124f20b4ce18d1d3d24fc7b88e68
>> 7e10bb&amp;data=02%7C01%7Ckuldeep.singh%40nxp.com%7Cee345bdf9f65
>> 44ac9f4508d79fd863d9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
>> 7C637153624041330774&amp;sdata=BTRzWWY2z6nZncyktDDIdJFwYTp41S%2
>> Buh99QaJ60e1M%3D&amp;reserved=0
>>
>>> Thanks
>>> Kuldeep
>>>
>>>>
>>>> Regards
>>>> Vignesh
>>>>
>>>>
>>>
>>
>> --
>> Regards
>> Vignesh

-- 
Regards
Vignesh