linux-kernel - Re: [PATCH] Add prctl support for controlling mem reclaim V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200127130258.2bknkl3mwpkfyml4@wittgenstein>
Date:   Mon, 27 Jan 2020 14:02:59 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Dave Chinner <david@...morbit.com>
Cc:     Mike Christie <mchristi@...hat.com>,
        Shakeel Butt <shakeelb@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-api@...r.kernel.org, idryomov@...il.com,
        Michal Hocko <mhocko@...nel.org>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-scsi@...r.kernel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-block@...r.kernel.org, martin@...ackup.org,
        Damien.LeMoal@....com, Michal Hocko <mhocko@...e.com>,
        Masato Suzuki <masato.suzuki@....com>
Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4

On Sat, Jan 25, 2020 at 08:16:42AM +1100, Dave Chinner wrote:
> On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote:
> > On 12/05/2019 04:43 PM, Shakeel Butt wrote:
> > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie <mchristi@...hat.com> wrote:
> > >> This patch adds a new prctl command that daemons can use after they have
> > >> done their initial setup, and before they start to do allocations that
> > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE
> > >> flags so both userspace block and FS threads can use it to avoid the
> > >> allocation recursion and try to prevent from being throttled while
> > >> writing out data to free up memory.
> > >>
> > >> Signed-off-by: Mike Christie <mchristi@...hat.com>
> > >> Acked-by: Michal Hocko <mhocko@...e.com>
> > >> Tested-by: Masato Suzuki <masato.suzuki@....com>
> > >> Reviewed-by: Damien Le Moal <damien.lemoal@....com>
> > > 
> > > I suppose this patch should be routed through MM tree, so, CCing Andrew.
> > >
> > 
> > Andrew and other mm/storage developers,
> > 
> > Do I need to handle anything else for this patch, or are there any other
> > concerns? Is this maybe something we want to talk about at a quick LSF
> > session?
> > 
> > I have retested it with Linus's current tree. It still applies cleanly
> > (just some offsets), and fixes the problem described above we have been
> > hitting.
> 
> I must have missed this version being posted (just looked it up on
> lore.kernel.org). As far as I'm concerned this is good to go and it
> is absolutely necessary for userspace IO stacks to function
> correctly.
> 
> Reviewed-by: Dave Chinner <dchinner@...hat.com>
> 
> If no manintainer picks it up before the next merge window, then I

Since prctl() is thread-management and fs people seem to be happy and
have acked it I can pick this up too if noone objects and send this
along with the rest of process management.

Christian