[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200127062456.GC570@unicorn.suse.cz>
Date: Mon, 27 Jan 2020 07:24:56 +0100
From: Michal Kubecek <mkubecek@...e.cz>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Jiri Pirko <jiri@...nulli.us>,
Florian Fainelli <f.fainelli@...il.com>,
John Linville <linville@...driver.com>,
Johannes Berg <johannes@...solutions.net>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET
request
On Mon, Jan 27, 2020 at 02:04:22AM +0100, Andrew Lunn wrote:
> > + ret = ethnl_parse_header(&req_info, tb[ETHTOOL_A_DEBUG_HEADER],
> > + genl_info_net(info), info->extack, true);
>
> > + dev_put(dev);
>
> Hi Michal
>
> While reviewing this patch i noticed this dev_put() and wondered where
> the dev_get() was. It is hiding inside ethnl_parse_header(). The
> documentation does make it clear it takes a reference on the device,
> but how many people read the documentation? I would not be too
> surprised if at some point in the future we have bugs from missing
> dev_put().
>
> Could we make this a bit more explicit by calling it
> ethnl_parse_header_dev_get(). It is rather long though.
Good point, I'll think about the name some more and send a cleanup patch
when net-next reopens.
Michal
Powered by blists - more mailing lists